Re: [lwip-users] std includes

[address@hidden]

timmy brolin wrote:
> In almost all lwIP *.c files, there are a couple of standard #includes 
> at the top, just after the lwip #includes.
> Such as "#include <string.h>" and "#include <stdlib.h>".
> These feel misplaced.
Well, I don't think they feel misplaced: including them in sys.h or 
arch.h would include them in files which don't use them, which is not a 
good thing to do.

I wouldn't have thought that this leads to problems on a standard C 
compiler. However, I do know of an AVR compiler that doesn't provide 
these files, so you might have a point in removing these includes, after 
all...?
In sys.h anc arch.h the user may define user defined implementations of 
common functions, replacing the library functions.
> If the standard libraries are to be included, then they should only be 
> included from the user portable files sys.h or arch.h.
I'm not a friend of global "includeall.h" header files...
> Can anyone come up with a reason why <string.h>, <stdlib.h>, 
> <stddef.h> and <stdio.h> should not be removed from all *.c files?
See above: header files should be included where they are used.

Anyone got any preferences on this?

Simon