Re: [lwip-users] DHCP usage with latest git code version

[Sylvain Rochet]

Hi Bram,


On Mon, Sep 14, 2015 at 12:40:52PM +0000, Bram Peeters wrote:
> Hi Sylvain, 
> 
> Sorry for the delay in responding, I took a slight detour running into ;p
>  http://lists.gnu.org/archive/html/lwip-devel/2012-01/msg00018.html
> 
> Anyway, before diving into the dhcp problem again I synced my lwip to 
> the latest sources (I was using something which was several weeks old 
> at this point) but now it just works even if I disable 
> LWIP_DHCP_CHECK_LINK_UP again.
> 
> I am not sure which exact change did it (there were like 99 files 
> which had changed), but it seems to be working now. ( Before the it 
> would be (and stay) in DHCP_STATE_OFF when I entered 
> dhcp_network_changed, now it is in state DHCP_STATE_SELECTING. )

Great! :) You probably fetched the master branch during the great API 
rework for IPv6 and the new netif flag (up/link up) behavior.


> BTW 1 small bug in the current sources (don't really know where to 
> report this so i will piggy back it here):
> 
> In tcp_out.c, function tcp_output_segment
> There is (around lines 1261) :
> 
> #endif /* CHECKSUM_GEN_TCP */
> }
> 
> 
> should be 
> 
> }
> #endif /* CHECKSUM_GEN_TCP */

Indeed, fixed, thanks for the hint.


Sylvain

signature.asc
Description: Digital signature