[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
lynx-dev messy code
From: |
Philip Webb |
Subject: |
lynx-dev messy code |
Date: |
Thu, 27 Aug 1998 11:11:25 -0400 (EDT) |
980827 Thomas Dickey wrote:
> 980826 Nelson Henry Eric wrote:
> > Could you easily explain what "hidden away in macros" means?
> A couple of examples:
>
> + the way I cleaned up the clutter in LYOptions.c -
> moving repetitive code into macros.
there seems to be a lot of it about: have a look at LYSearch.c 158-385
the twin sections if (recall ... & else if (recall ... .
> + the cleanup of the temporary file handling functions
> (instead of plastering the code with #if VMS/#else/#if DOSPATH/#else/...,
> move structurally-similar stuff into macros or functions.
> (When I'm reading code, a preprocessor line is distracting).
i suspect a lot of Lynx code was in fact written rather hastily.
that's no criticism of the authors, but we shouldn't be too in awe of it.
--
========================,,============================================
SUPPORT ___________//___, Philip Webb : address@hidden
ELECTRIC /] [] [] [] [] []| Centre for Urban & Community Studies
TRANSIT `-O----------O---' University of Toronto
- lynx-dev when, where, why "kb/sec"? Any votes for a "simple" Lynx, Nelson Henry Eric, 1998/08/26
- Re: lynx-dev when, where, why "kb/sec"? Any votes for a "simple" Lynx, dickey, 1998/08/26
- Re: lynx-dev when, where, why "kb/sec"? Any votes for a "simple" Lynx, Nelson Henry Eric, 1998/08/26
- Re: lynx-dev when, where, why "kb/sec"? Any votes for a "simple" Lynx, dickey, 1998/08/27
- Re: lynx-dev when, where, why "kb/sec"? Any votes for a "simple" Lynx, Nelson Henry Eric, 1998/08/27