lynx-dev Re: BUG (weird one): long filenames, specialized downloader, other stuff

[Webmaster Jim]

On Wed, Apr 28, 1999 at 02:39:57AM -0400, John Bley wrote:
> On Tue, 27 Apr 1999, Kim DeVaughn wrote:
> 
> > In WWW/Library/Implementation/HTUtils.h:98, LY_MAXPATH is define'd
> > as 256.  Perhaps bumping that up will do the trick, depending on
> > just how long, long is.
> > 
> > Since it's reproducible at your end, why not increase it to (say)
> > something like 1024, and see if that fixes things?
> 
> I tried 2048 on a whim, and this indeed fixed the problem.  This probably 
> means that some function needs to be switched to its bounded variant.  
> The fact that it crashed given this off-the-web long name means that either
>  a) some function(s) need to be switched to their bounded variants
>  b) The fixed buffer size needs to be either increased or removed
>  c) An off-the-web file name that goes beyond the limit should be 
>     truncated before being displayed to the user.
> 
> Again, I'll take a look when I have some time.  (c) seems like a good first 
> guess at how to really fix this.

I started looking at various char buffers that have numbers rather
than defined lengths.  There are a lot of them, e.g.:
LYCookie.c:    static char domain[256], path[LY_MAXPATH], name[256], 
value[4100];

LYLocal.c:    char newpath[512];
LYLocal.c:    char savepath[512];
LYMain.c:    char buf[1024];


------
<http://www.cs.indiana.edu/picons/db/users/us/md/lib/bcpl/jspath/face.xbm>
<http://www.altavista.com/cgi-bin/query?q=%22web+home+for+jim+spath%22>
Marvin the Paranoid Android says:
Not that I'm really unlucky, it's just been    
one of those millenia so far you know.