Re: [Lynx-dev] [Patch] Lynx won't compile against zlib 1.2.5.1

[Bela Lubkin]

Tom Dickey wrote:

Nikos Chantziaras wrote:

> > Trying to build Lynx with zlib 1.2.5.1 results in build errors, due to the
> > 'ON' macro of zlib, which conflicts with the one in LYUtils.h. Here's a bug
> > report about it on Gentoo's tracker:
> >
> >  https://bugs.gentoo.org/show_bug.cgi?id=383113
> >
> > A patch that fixes the problem by renaming Lynx's ON and OFF macros to LON
> > and LOFF:
> >
> >  https://383113.bugs.gentoo.org/attachment.cgi?id=286575

> ON/OFF are on the other hand unnecessary in lynx altogether - making them
> TRUE/FALSE would be simpler (similar to BOOL vs BOOLEAN, but different
> since the latter are typed).

It's good that you've fixed this in Lynx.  The triggering bug here,
however, is that zlib 1.2.5.1 introduced these bogus ON/OFF macros.
Gentoo has picked that up:

   https://bugs.gentoo.org/show_bug.cgi?id=383179

(and related bugs 383347 383349 383351 383371).

The issue has already been raised on the zlib-devel mailing list:

   
http://mail.madler.net/pipermail/zlib-devel_madler.net/2011-September/002621.html

-- although not yet substantively responded to.

>Bela<