Re: FYI: 8-gary-obstack-portability.patch

[Gary V. Vaughan]

On Mon, Sep 10, 2001 at 09:42:52AM +0200, Akim Demaille wrote:
> 
> | Index: m4/Makefile.am
> | ===================================================================
> | RCS file: /cvsroot/m4/m4/m4/Makefile.am,v
> | retrieving revision 1.10
> | diff -u -p -u -r1.10 Makefile.am
> | --- m4/Makefile.am 2001/09/01 20:05:27 1.10
> | +++ m4/Makefile.am 2001/09/06 20:11:40
> | @@ -25,12 +25,13 @@ MODULE_PATH             = $(pkglibexecdir)
> |  pkgincdir          = $(includedir)/@PACKAGE@
> |  
> |  LDFLAGS    = -no-undefined -export-dynamic
> | -INCLUDES   = -I$(top_srcdir) -I$(top_srcdir)/src @INTLINCL@
> | +INCLUDES   = -I$(top_builddir) -I$(top_srcdir) \
> 
> Why -I$(top_srcdir)?  config.h is not there.

So the `#include <m4/m4module.h>' and the like will work in the source
tree.

> | +             -I$(top_builddir)/src -I$(top_srcdir)/src @INTLINCL@
> |  
> |  include_HEADERS    = m4module.h
> |  noinst_HEADERS     = m4private.h
> |  pkginc_HEADERS     = error.h hash.h ltdl.h regex.h system.h @OBSTACK_H@
> | -EXTRA_HEADERS      = gnu-obstack.h
> | +EXTRA_HEADERS      = system-h.in gnu-obstack.h
> |  
> |  EXTRA_DIST = $(EXTRA_HEADERS) obstack.c
> |  
> | @@ -44,3 +45,7 @@ libm4_la_LIBADD           = @LTLIBOBJS@ @LIBADD_D
> |  module.o module.lo: $(srcdir)/module.c pathconf.h
> |  pathconf.h: Makefile
> |     @echo "#define MODULE_PATH \"${MODULE_PATH}\"" > pathconf.h
> | +
> | +# This file needs to be regenerated at configure time.
> | +dist-hook:
> | +   rm -f $(distdir)/system.h
> 
> I don't understand why it's hook on dist.  Doesn't using 
> 
>    nodist_pkginc_HEADERS = system.h  @OBSTACK_H@
>    dist_pkginc_HEADERS = error.h hash.h ltdl.h regex.h
> 
> fix the issue?

Just a stylistic thing.  The double qualified primaries arrived after
I started using dist-hook.  Change it if you like...

Cheers,
        Gary.
-- 
  ())_. Gary V. Vaughan     gary@(oranda.demon.co.uk|gnu.org)
  ( '/  Research Scientist  http://www.oranda.demon.co.uk       ,_())____
  / )=  GNU Hacker          http://www.gnu.org/software/libtool  \'      `&
`(_~)_  Tech' Author        http://sources.redhat.com/autobook   =`---d__/