[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
FYI: fix recursive push_string bug [m4--release--1.4--patch-15]
From: |
Gary V. Vaughan |
Subject: |
FYI: fix recursive push_string bug [m4--release--1.4--patch-15] |
Date: |
Sun, 4 Dec 2005 20:17:56 +0000 (GMT) |
User-agent: |
mailnotify/0.7 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Applied to branch-1_4.
* looking for address@hidden/m4--release--1.4--patch-14 to compare with
* comparing to address@hidden/m4--release--1.4--patch-14
M src/input.c
M ChangeLog
M NEWS
* modified files
Index: Changelog
from Ilya N. Golubev <address@hidden> (tiny change)
* input.c (match_input): Do not pass expression with side effect
to `obstack_grow'. Fix <INTERNAL ERROR: Recursive push_string!>.
* NEWS: Updated.
2005-12-04 Gary V. Vaughan <address@hidden> (tiny change)
--- orig/NEWS
+++ mod/NEWS
@@ -1,6 +1,10 @@
GNU m4 NEWS - User visible changes.
Copyright (C) 1992, 1993, 1994, 2004, 2005 Free Software Foundation, Inc.
+Version 1.4.5 - ??? 200?, by ???
+
+* Fix a recursive push_string crashing bug.
+
Version 1.4.4 - October 2005, by Gary V. Vaughan
* ./configure --infodir=/usr/share/info now works correctly.
--- orig/src/input.c
+++ mod/src/input.c
@@ -531,7 +531,12 @@
}
/* Failed, push back input. */
- obstack_grow (push_string_init (), t, n);
+ {
+ struct obstack *h = push_string_init ();
+
+ /* `obstack_grow' may be macro evaluating its arg 1 several times. */
+ obstack_grow (h, t, n);
+ }
push_string_finish ();
return 0;
}
- --
Gary V. Vaughan ())_. address@hidden,gnu.org}
Research Scientist ( '/ http://tkd.kicks-ass.net
GNU Hacker / )= http://www.gnu.org/software/libtool
Technical Author `(_~)_ http://sources.redhat.com/autobook
_________________________________________________________
This patch notification generated by tlaapply version 1.0
http://tkd.kicks-ass.net/arch/address@hidden/cvs-utils--tla--1.0
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (Darwin)
iD8DBQFDk07zFRMICSmD1gYRAh/mAJ0cqArNVtjC3ifUaXb/kb2iYNBwkACfSBFq
1KtdTs9BsEycdN9tT/xsjWQ=
=I9HF
-----END PGP SIGNATURE-----