Re: add gmp library dependency; get dist to work...

[Eric Blake-1]

Hi Ralf,

> This seems to have gotten lost during some of the restructuring,
> see the first patch below.  It fixes a test failure:
> | 12: gmp                                           FAILED
> (builtins.at:301)

I see it fail on cygwin, as well, but suspect a bigger problem with
libtool, as I am getting failures on all tests that attempt dynamic
loading; and your patch didn't solve the failure on cygwin:

12. builtins.at:178: testing ...
./builtins.at:181: test "$USE_GMP" = yes || exit 77
./builtins.at:301: m4 -b -d -m mpeval in
--- /dev/null   2006-06-05 16:11:00.105000000 -0600
+++ /home/eblake/m4-head/tests/testsuite.dir/at-stderr  2006-06-05
16:11:00.0581
25000 -0600
@@ -0,0 +1 @@
+m4: cannot open module `mpeval': can't open the module


> 
> (and yes, in order to be able to even get `make' to succeed, I need to
> fiddle with gnulib getopt currently; __getopt_argv_const is not #defined
> in my system getopt.h, but it's used unconditionally in src/getopt1.c).

Can you report that to gnulib?

> 
> 
> FWIW, I currently get one other failure:
> | 52: [Erenamesyms and Renamesyms]                  FAILED
> (generated.at:352)
> 
> due to a segmentation fault of m4:

I've seen this, too, and have been meaning to get this solved;
I suspect that forward porting some of the symbol table cleanups
from 1.4.x will help.

> 
> If I kill that test, do the getopt munging, and apply the other trivial
> patch below, and shorten out the two(!) NEWS checks (one inserted by
> Makefile.am, the other by Automake, as documented), I can get `make
> dist' to succeeed -- yay!

The Makefile.am one is for cvs-dist, although that should probably be
pulled out of Makefile.am and use gnulib's Makefile.maint instead (it's
on my todo list).  But in the meantime, I can at least fix its typo.

> 
> distcheck then fails because installcheck fails these tests:
> |  34: modules.at:27      Freezing modules
> |  41: modules.at:135     modules: shadow
> |  42: modules.at:275     modules: unload
> |  43: modules.at:348     modules: importing
> |  44: modules.at:406     modules: trace
> 
> with failures all similar to this one:
> | +m4: input.m4: 12: cannot open module `shadow': file not found

Again, I was seeing similar failures on cygwin, such as:

34. modules.at:27: testing frozen.m4f...
./modules.at:52: m4 -b -d -m load frozen.m4 unfrozen.m4
stderr:
m4: cannot open module `load': can't open the module

> 
> I'll leave that for you to find out.
> 
> Cheers,
> Ralf
> 
>       * Makefile.am (modules_mpeval_la_LIBADD): Readd $(LIBADD_GMP).

Will check in shortly.

> 
>       * Makefile.am (EXTRA_DIST): doc/helptoman.pl is gone.

Checked in as follows:

2006-06-13  Ralf Wildenhues  <address@hidden>
            Eric Blake  <address@hidden>

        Allow `make dist' to work again.
        * Makefile.am (EXTRA_DIST): doc/helptoman.pl is gone.
        (MAINTAINERCLEANFILES): Avoid redundant mention of dist_man_MANS.
        (cvs-dist): Fix typo.
        * NEWS: Match current version number.


Pardon the nabble footer, I'm not on my normal machine.


Index: Makefile.am
===================================================================
RCS file: /sources/m4/m4/Makefile.am,v
retrieving revision 1.27
diff -u -r1.27 Makefile.am
--- Makefile.am 13 Jun 2006 15:41:38 -0000      1.27
+++ Makefile.am 13 Jun 2006 16:28:57 -0000
@@ -244,7 +244,6 @@
 
 info_TEXINFOS  = doc/m4.texinfo
 dist_man_MANS  = doc/m4.1
-MAINTAINERCLEANFILES += $(dist_man_MANS)
 
 doc/m4.1: $(srcdir)/configure.ac $(srcdir)/src/main.c
        @if test -f src/m4$(EXEEXT); then \
@@ -263,8 +262,6 @@
 ## TAGS_DEPENDENCIES = $(TAGS_FILES)
 ## ETAGS_ARGS  = --language=none --regex='/@node \([^,]*\)/\1/'
$(TAGS_FILES)
 
-EXTRA_DIST     += doc/helptoman.pl
-
 MAINTAINERCLEANFILES += $(dist_man_MANS)
 
 
@@ -421,8 +418,8 @@
 # Tag before making distribution.  Also, don't make a distribution if
 # checks fail.  Also, make sure the NEWS file is up-to-date.
 cvs-dist: distcheck # maintainer-check
-       @if sed '1,2d;3q' $(srcdir)/NEWS | grep -e $(VERSION)" > dev/null; \
-         echo "NEWS not updated not releasing" 1>&2; \
+       @if sed '1,2d;3q' $(srcdir)/NEWS | grep -e "$(VERSION)" > dev/null; \
+         echo "NEWS not updated; not releasing" 1>&2; \
          exit 1;
        fi
        cd $(srcdir) && \
Index: NEWS
===================================================================
RCS file: /sources/m4/m4/NEWS,v
retrieving revision 1.10
diff -u -r1.10 NEWS
--- NEWS        15 Jul 2003 09:06:24 -0000      1.10
+++ NEWS        13 Jun 2006 16:28:57 -0000
@@ -1,7 +1,8 @@
 GNU m4 NEWS - History of user-visible changes.         -*- outline -*-
-Copyright 1992, 1993, 1994, 1998, 2000, 2001 Free Software Foundation, Inc.
+Copyright 1992, 1993, 1994, 1998, 2000, 2001, 2006 Free Software
+Foundation, Inc.
 
-Version beta 1.4r - ???, by ???
+Version beta 1.9a - ???, by ???
 
 * If the POSIXLY_CORRECT environment variable is set, m4 now disables
   GNU extensions that are incompatible with POSIX.

--
View this message in context: 
http://www.nabble.com/add-gmp-library-dependency--get-dist-to-work...-t1781106.html#a4850329
Sent from the Gnu - M4 - Patches forum at Nabble.com.