[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: FWD: Make CVS 7X slower on Win32 NTFS than beta 4
From: |
Eli Zaretskii |
Subject: |
Re: FWD: Make CVS 7X slower on Win32 NTFS than beta 4 |
Date: |
Fri, 10 Feb 2006 20:48:01 +0200 |
> From: "J. David Bryan" <address@hidden>
> Date: Fri, 10 Feb 2006 11:55:54 -0500
> CC: "Paul D. Smith" <address@hidden>, address@hidden
>
> Presuming "dir->dirstream == 0", the beta4 version of this code returns 0
> if the file system is NTFS and the directory time hasn't changed, as the
> else-clause just below the "#endif" is taken. With your patch, the same
> scenario falls into the while loop and so calls "readdir" with
> "dir->dirstream == 0". Is that correct? If not, then perhaps the "if
> (rehash)" just above needs an "else return 0;".
Right again, thanks. Paul, the patch to fix this blunder is below.
> By the way, thanks for your work on -jN. It works well on the dual-core
> machine here and was my primary motivator for trying out the CVS version.
You are welcome.
--- dir.c~2 2006-02-10 12:24:43.475125000 +0200
+++ dir.c 2006-02-10 20:44:33.959500000 +0200
@@ -652,6 +652,8 @@ dir_contents_file_exists_p (struct direc
if (!dir->dirstream)
return 0; /* couldn't re-read - fail */
}
+ else
+ return 0; /* it has been already read in */
}
else
#endif