make-w32
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: GNU make 3.81rc1 released -- please test.


From: J. David Bryan
Subject: Re: GNU make 3.81rc1 released -- please test.
Date: Fri, 24 Feb 2006 13:06:28 -0500

On 24 Feb 2006 at 13:42, Eli Zaretskii wrote:

> --- job.c~0   2006-02-20 06:14:01.000000000 +0200
> +++ job.c     2006-02-24 13:33:57.828125000 +0200
> @@ -2770,8 +2770,13 @@ construct_command_argv_internal (char *l
>      /* Some shells do not work well when invoked as 'sh -c xxx' to run a
>         command line (e.g. Cygnus GNUWIN32 sh.exe on WIN32 systems).  In these
>         cases, run commands via a script file.  */
> -    if (just_print_flag)
> -      ; /* Do nothing here.  */
> +    if (just_print_flag) {
> +      /* Need to allocate new_argv, although it's unused, because
> +      start_job_command will want to free it and its 0'th element.  */
> +      new_argv = (char **) xmalloc(2 * sizeof (char *));
> +      new_argv[0] = xstrdup ("");
> +      new_argv[1] = NULL;
> +    }
>      if ((no_default_sh_exe || batch_mode_shell) && batch_filename_ptr) {
>        int temp_fd;
>        FILE* batch = NULL;

I believe that the "if ((no_default_sh_exe..." statement following your 
changed lines should be an "else if" -- otherwise, it's executed even if 
"just_print_flag" is true, and so the batch file is created (and then not 
subsequently purged).

                                      -- Dave





reply via email to

[Prev in Thread] Current Thread [Next in Thread]