make-w32
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Make CVS (Win32) improperly leaves batch files with -n


From: Eli Zaretskii
Subject: Re: Make CVS (Win32) improperly leaves batch files with -n
Date: Fri, 24 Feb 2006 13:39:05 +0200

> From: "J. David Bryan" <address@hidden>
> Date: Sun, 19 Feb 2006 16:23:19 -0500
> CC: address@hidden
> 
> It appears to me that this patch will cause a double "free" in 
> "start_job"command" (job.c).

I think I fixed this, thanks.  (The actual patch will be sent
separately.)

> One solution might be to set "new_argv" to null in "if" statement added by 
> the patch, and then condition the free in the "-n" case in 
> "start_job_command" on a non-null value.

I've chosen a simpler way out: allocate an empty argument list and let
start_job_command free it.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]