[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Problems with latest Cygwin make patch; builds OK but binary segfaul
Re: Problems with latest Cygwin make patch; builds OK but binary segfaults
Fri, 25 Aug 2006 08:53:18 -0400
> From: "William Sheehan" <address@hidden>
> Date: Fri, 25 Aug 2006 00:57:35 -0700
> The basic cause of the problems are the ~ and ! characters defined in
> sh_chars, line 2304 of job.c in the untouched make 3.81 sources. Or rather,
> that a Cygwin build uses sh_chars when (I think) it should be using
> sh_chars_sh. While the patch does try to address this by adding a new
> #ifdef HAVE_DOS_PATHS for sh_chars_sh around line 2309, it doesn't seem to
> account for the use of sh_chars on lines 2462 and 2751.
> On those two lines (2462 and 2751), I did a quick #ifdef HAVE_DOS_PATHS that
> substituted sh_chars_sh instead of sh_chars, and all of the problems I had
> before went away. Whether this is a proper fix or not I am not sure; I'm
> starting to grasp the logic used in the function, but not quite to zen yet
Please rune "make check" on the version of Make you think fixes the
problem. If all the tests pass, please post here a patch that you
used to fix the recursion problem. Thanks.
> > This is a standard feature of GNU Patch: if the patch file
> > names the file config/dospaths.m4, Patch will look in the
> > config/ subdirectory. What command did you use to invoke
> > Patch, and what version of Patch is that?
> I just used the latest patch package from the Cygwin installer. The patch
> commands were in my attached .script file. I figured it was a version
> issue; thanks for the heads up.
No, it wasn't a version issue: your Patch command lacks the -p0
switch, which I think is the cause of your trouble.
Thanks again for working on this.
Re: Problems with latest Cygwin make patch; builds OK but binary segfaults, William A. Hoffman, 2006/08/24