[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: command line limit in mingw-make

From: Jonathan Liu
Subject: Re: command line limit in mingw-make
Date: Wed, 12 Sep 2012 20:45:39 +1000
User-agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:10.0) Gecko/20120206 Thunderbird/10.0

On 3/09/2012 3:20 AM, Eli Zaretskii wrote:
Date: Sun, 02 Sep 2012 21:26:14 +1000
From: Jonathan Liu<address@hidden>
CC: Joe Burmeister<address@hidden>, address@hidden

A quick test with CreateProcess seams to show it's not necessary for
this to trigger an intermediate batch file.
Probably.  Can you try building make.exe with MinGW, after removing
the " character from sh_chars_dos[] defined on job.c under WINDOWS32?

(Building a MinGW Make requires to run the build_w32.bat batch file;
see the file README.W32 for instructions.)
I have removed the " character from sh_chars_dos and it works.
I can now build qt5 qtwebkit which has really long command lines (around
12000 characters long). Also, quoted filenames that have spaces still
work fine in Makefiles.

Could this be change applied to CVS?
I'll add this to my TODO.  Thanks for testing.
Patch attached for reference.

Attachment: win32-shell-remove-double-quote.patch
Description: Text document

reply via email to

[Prev in Thread] Current Thread [Next in Thread]