Re: [Maposmatic-dev] [PATCH maposmatic] Improve the file cleanup mechanism

[Maxime Petazzoni]

Hi,

* David MENTRE <address@hidden> [2010-01-13 15:25:48]:

> Hello Maxime,
> 
> 2010/1/13 Maxime Petazzoni <address@hidden>:
> > CAUTION: this change alters the database layout! The new column is:
> >    "has_files" bool NOT NULL
> 
> Why not use another value is current column used for the state
> (waiting, rendered, done)?

That's a good idea. We could extend this to (waiting, rendered, done,
done_no_files). I'll rework the patch to do that instead.

> >  * thumbnails of jobs in the database are always kept, so we can
> >    display what the map looked like even if we don't have the files
> >    around anymore;
> 
> Risk of filling the database with such images? Is it of any use?

I don't think so. Thumbnails are small (~40k/each). More thumbnails will
just mean a few less job files kept (when you think some jobs generate
40MB of renderings, that's a thousand more thumbnails you can keep).

And I think having the thumbnails to display on old jobs without files
is better.

- Maxime

-- 
Maxime Petazzoni <http://www.bulix.org>
 ``One by one, the penguins took away my sanity.''
Linux kernel and software developer at MontaVista Software

signature.asc
Description: Digital signature