Re: [Maposmatic-dev] Pango support for OcitySMap

[Maxime Petazzoni]

Hi,

* Thomas Petazzoni <address@hidden> [2010-02-24 00:30:20]:

> Here is a resend of my patch set implementing the usage of Pango. I've
> fixed the obvious "def isrtl(): return True" mistake, and ordered the
> imports in street_index as suggested.

Excellent.

> Concerning the other issues (not hardcoding the font name and adding
> docstrings), while they are perfectly valid, they are issues that
> already exist in the current code. Therefore, I'd like to handle them
> separatly from the changes proposed in this patch set.

Fine with me, as long as it gets done eventually.

> The font name hardcoding solution for example is fairly hard to
> implement cleanly without a proper reorganization of OcitySMap source
> code, which is outside of the scope of this patch set.

Ok.

The series LGTM, I'll integrate them today and deploy on
dev.maposmatic.org so we can test it out.

- Maxime
-- 
Maxime Petazzoni <http://www.bulix.org>
 ``One by one, the penguins took away my sanity.''
Linux kernel and software developer at MontaVista Software

signature.asc
Description: Digital signature