[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Maposmatic-dev] [PATCH] Adding links from jobs to OpenStreetMap mai
From: |
Maxime Petazzoni |
Subject: |
Re: [Maposmatic-dev] [PATCH] Adding links from jobs to OpenStreetMap main site |
Date: |
Wed, 4 Aug 2010 21:45:40 +0200 |
User-agent: |
Mutt/1.5.20 (2009-06-14) |
Hi Pierre,
This is a lot better. I have one last remark though, see below.
* Pierre Mauduit <address@hidden> [2010-08-04 19:40:48]:
> + {% if job.administrative_city %}
> + <a href="http://www.osm.org?relation={{ job.administrative_osmid|abs
> }}">{% trans "View on OpenStreetMap" %}</a>
> + {% else %}
> + <a href="http://www.osm.org?maxlat={{ job.lat_upper_left
> }}&maxlon={{ job.lon_bottom_right }}&minlat={{ job.lat_bottom_right
> }}&minlon={{ job.lon_upper_left }}">{% trans "View on OpenStreetMap"
> %}</a>
> + {% endif %}
This would be better as:
<a href="http://osm.org/?{% if job.administrative_city %}relation={{
job.administrative_osmid|abs }}{% else %}maxlat=...{% endif %}">{% trans "View
on OpenStreetMap" %}</a>
Thanks !
- Maxime
--
Maxime Petazzoni <http://www.bulix.org>
``One by one, the penguins took away my sanity.''
Linux kernel and software developer at MontaVista Software
signature.asc
Description: Digital signature