[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [GMG-Devel] Thumbnail handling branch ready for pulling (issue 533)

From: Christopher Allan Webber
Subject: Re: [GMG-Devel] Thumbnail handling branch ready for pulling (issue 533)
Date: Wed, 14 Nov 2012 10:50:35 -0600
User-agent: mu4e 0.9.9-dev6; emacs

Heya Spaetz:

Sorry for being so behind on replying to things.  Awesome work on
this... I added a relevant comment here:

I think it's great, and with that resolved, mergable!
 - Chris

Sebastian Spaeth writes:

> I created to track this.
> This is pre-work for the PDF media type handling which is supposed to 
> show default pdf fallback icons in the beginning. It works by adding a 
> MediaEntry.thumb_url property that template designers can use.
> Rather than:
> {{['thumb']) }}
> you can use:
> {{ media_entry.thumb_url }}
> This is automatically fall back to the static default icon as configured 
> in the media's MEDIA_MANAGER['default_thumb'].
> It also adds a default "image" fallback icon (the configured URL did not 
> exist), based on the Public-Domain Tango icon. Our esteemed web designer 
> might want to replace it with a proper "broken image" icon?
> Code is tested and works for me. I am bad at writing tests though, not 
> sure how I would write one for this.
> Spaetz
> The code is in branch get_thumb_url on 
> git://
> The patch in question is: 
> _______________________________________________
> devel mailing list
> address@hidden

reply via email to

[Prev in Thread] Current Thread [Next in Thread]