Re: [GMG-Devel] Pull requests on Gitorious

[Christopher Allan Webber]

Thanks Jim!  This is great!

I will probably get to this right after the release.


Jim Campbell writes:

> Hi All,
>
> I've reviewed the following documentation merge requests:
>
> https://gitorious.org/mediagoblin/mediagoblin/merge_requests/31
> https://gitorious.org/mediagoblin/mediagoblin/merge_requests/34
> https://gitorious.org/mediagoblin/mediagoblin/merge_requests/38
> https://gitorious.org/mediagoblin/mediagoblin/merge_requests/43
> https://gitorious.org/mediagoblin/mediagoblin/merge_requests/55
>
> I've added comments to the bottom of each one. Please see my comments, and
> then either close the merge, apply the merge, ask an additional question,
> or something else of your choosing.  : )
>
> That leaves the merge request that I proposed:
>
> https://gitorious.org/mediagoblin/mediagoblin/merge_requests/59
>
> Please review it for any technical details. I tried to make clear things up
> - make it easier for someone to follow-along and deploy mediagoblin.
> However, I think some of the style may be a bit dry (especially in the
> earlier portions). If the technical details are ok, I can rewrite the
> descriptive text a bit more informally. Let me know what you think.
>
> Thanks,
>
> Jim
>
>
>
> On Fri, May 24, 2013 at 10:36 AM, Christopher Allan Webber <
> address@hidden> wrote:
>
>> Stellar!  Closed those out.  We're now down to only 13 left.
>>
>> Rj Ewing writes:
>>
>> > Here's some more:
>> >
>> > http://gitorious.org/mediagoblin/mediagoblin/merge_requests/17
>> > http://bugs.foocorp.net/issues/298
>> >
>> > http://gitorious.org/mediagoblin/mediagoblin/merge_requests/19
>> > http://bugs.foocorp.net/issues/519
>> >
>> > http://gitorious.org/mediagoblin/mediagoblin/merge_requests/23
>> > http://bugs.foocorp.net/issues/444#note-7
>> >
>> > http://gitorious.org/mediagoblin/mediagoblin/merge_requests/24
>> > http://bugs.foocorp.net/issues/614
>> >
>> > http://gitorious.org/mediagoblin/mediagoblin/merge_requests/25
>> > http://bugs.foocorp.net/issues/608
>> >
>> > http://gitorious.org/mediagoblin/mediagoblin/merge_requests/26
>> > http://bugs.foocorp.net/issues/601
>> >
>> > http://gitorious.org/mediagoblin/mediagoblin/merge_requests/27
>> > http://bugs.foocorp.net/issues/469
>> >
>> > http://gitorious.org/mediagoblin/mediagoblin/merge_requests/30
>> > http://bugs.foocorp.net/issues/653
>> >
>> > http://gitorious.org/mediagoblin/mediagoblin/merge_requests/33
>> > http://bugs.foocorp.net/issues/544
>> >
>> > http://gitorious.org/mediagoblin/mediagoblin/merge_requests/37
>> > http://issues.mediagoblin.org/ticket/255
>> >
>> > http://gitorious.org/mediagoblin/mediagoblin/merge_requests/44
>> > Don't have a link to the ticket, but the changes are in the current code
>> >
>> > That's all for now, but if Jim goes reviews the doc related merge
>> requests,
>> > there should only be a couple left.
>> >
>> >
>> > On Fri, May 17, 2013 at 3:27 PM, Christopher Allan Webber <
>> > address@hidden> wrote:
>> >
>> >> Thanks for the heads up; closed!  Help like this in cleaning up the list
>> >> is appreciated! :)
>> >>
>> >> Rj Ewing writes:
>> >>
>> >> > I was looking through some of the merge requests, and it looks like a
>> lot
>> >> > of them, especially the older ones, are already merged.
>> >> >
>> >> > Ex.
>> >> > http://gitorious.org/mediagoblin/mediagoblin/merge_requests/23
>> >> > http://bugs.foocorp.net/issues/444#note-7
>> >> >
>> >> >
>> >> > On Fri, May 17, 2013 at 10:53 AM, Christopher Allan Webber <
>> >> > address@hidden> wrote:
>> >> >
>> >> >> That would work great.
>> >> >>
>> >> >> Jim Campbell writes:
>> >> >>
>> >> >> > I can review some of the documentation-related merge requests. Can
>> >> get to
>> >> >> > them this weekend.
>> >> >> >
>> >> >> > It looks like some of them may be going over some of the same sets
>> of
>> >> >> > files. I can try to merge them together, fix any conflicts, and
>> then
>> >> >> > re-submit upstream for review . . . would that work? I don't really
>> >> see a
>> >> >> > pretty way of handling things otherwise.
>> >> >> >
>> >> >> > Jim
>> >> >> >
>> >> >> >
>> >> >> > On Tue, May 14, 2013 at 9:25 AM, Christopher Allan Webber <
>> >> >> > address@hidden> wrote:
>> >> >> >
>> >> >> >> Heya all,
>> >> >> >>
>> >> >> >> So you're right in observing that merge requests in gitorious get
>> >> mostly
>> >> >> >> ignored.
>> >> >> >>
>> >> >> >> I created an issue about this not too long ago:
>> >> >> >>   http://issues.mediagoblin.org/ticket/693
>> >> >> >>
>> >> >> >> Basically, merge requests aren't within our normal workflow of
>> >> feature
>> >> >> >> adding, which is described on our wiki:
>> >> >> >>   http://wiki.mediagoblin.org/Git_workflow
>> >> >> >>
>> >> >> >> This means I'm often failing to pay attention to merge requests.
>>  The
>> >> >> >> ticket I posted above has the goal of removing merge requests and
>> >> >> >> migrating the old ones.  Nonetheless, I've put both of your merge
>> >> >> >> requests onto my "review queue" so I'll try to get to them soon.
>> >> >> >>
>> >> >> >> I could use help with that above ticket, though.  Triaging all
>> those
>> >> old
>> >> >> >> merge requests is going to be... a lot of work. :)  If anyone
>> thinks
>> >> >> >> they can help either by assisting with review or moving them over
>> to
>> >> the
>> >> >> >> issue tracker, I'd appreciate it.
>> >> >> >>
>> >> >> >>  - Chris
>> >> >> >>
>> >> >> >> Benjamin Lebsanft writes:
>> >> >> >>
>> >> >> >> > #54 would be nice too, although no need to use 100 for the jpeg
>> >> >> >> > compression settings.
>> >> >> >> >
>> >> >> >> > Bye
>> >> >> >> > Ben
>> >> >> >> >
>> >> >> >> > Am 14.05.2013 13:48, schrieb Sam Tuke:
>> >> >> >> >> Hi all,
>> >> >> >> >>
>> >> >> >> >> I submitted a pull request for a very simple
>> documentation-related
>> >> >> >> >> commit a week ago[1]. I'm just wondering if anyone is
>> monitoring
>> >> pull
>> >> >> >> >> requests to the repo? Seems like there are quite a few waiting
>> >> pull
>> >> >> >> >> requests from others with no comments from the core team[2].
>> >> >> >> >>
>> >> >> >> >> Best,
>> >> >> >> >>
>> >> >> >> >> Sam.
>> >> >> >> >>
>> >> >> >> >> 1.
>> >> https://gitorious.org/mediagoblin/mediagoblin/merge_requests/58
>> >> >> >> >> 2.
>> https://gitorious.org/mediagoblin/mediagoblin/merge_requests
>> >> >> >> >> _______________________________________________
>> >> >> >> >> devel mailing list
>> >> >> >> >> address@hidden
>> >> >> >> >> http://lists.mediagoblin.org/listinfo/devel
>> >> >> >> >>
>> >> >> >> >
>> >> >> >> > _______________________________________________
>> >> >> >> > devel mailing list
>> >> >> >> > address@hidden
>> >> >> >> > http://lists.mediagoblin.org/listinfo/devel
>> >> >> >>
>> >> >> >> _______________________________________________
>> >> >> >> devel mailing list
>> >> >> >> address@hidden
>> >> >> >> http://lists.mediagoblin.org/listinfo/devel
>> >> >> >>
>> >> >>
>> >> >> _______________________________________________
>> >> >> devel mailing list
>> >> >> address@hidden
>> >> >> http://lists.mediagoblin.org/listinfo/devel
>> >> >>
>> >>
>> >>
>>
>>