Re: [GMG-Devel] URL issues for non-local storage

[ayleph]

On 11/01/2015 10:19 PM, Dylan Jeffers wrote:
> Ayleph,
> 
> Thanks for being on top of this issue. Agreed that this solution is not
> particularly flexible, but I am good with this for the time being.
> 
> Dylan
> 
> On 11/01/2015 10:13 PM, ayleph wrote:
>> On 10/31/2015 02:01 AM, ayleph wrote:
>>> On 10/27/2015 01:00 AM, Dylan Jeffers wrote:
>>>> Hi all,
>>>>
>>>> Wanted to start a dialogue about a particular issue (see link below)
>>>> where the URL to a media gets mangled if it's stored non-locally. When
>>>> using PyPump, or Goblinoid, it is impossible to view the media. As this
>>>> issue occurs with one of our best instances, pump.goblinrefuge.com, it
>>>> would be great if we could figure it out. I am willing to take it on
>>>> with a bit of assistance, if this bug is indeed something you all feel
>>>> we should address.
>>>
>>> I've figured out what the problem is, but I'm not sure how to solve it.
>>> The API assumes all thumbs and full images live on the pump host, so the
>>> API prepends the pump host URL to all locations returned by the storage
>>> object. We may need a switch in there that simply returns the image URL
>>> if files are hosted externally and prepends the pump host if files are
>>> hosted locally.
>>>
>>> More details here: https://issues.mediagoblin.org/ticket/5342#comment:1
>>
>> I've provided one possible solution to this issue. It's tested working
>> on one of my development instances. Details at the link below.
>>
>> https://issues.mediagoblin.org/ticket/5342#comment:2

I've started testing this on my real public instance, and there's an
interesting issue I found that might be related to an issue sapienTech
noticed. Using the "Pumpa" client, the Inbox page includes not only
media seen on the front page of my instance, but "graveyard" (deleted
activities) as well. Since images for deleted activities no longer
exist, the storage object returns the default image thumbnail (the same
one that was seen when testing on larjona's instance):
mgoblin_static/images/media_thumbs/image.png. As a side effect of this
behavious, Pumpa has a bunch of broken thumbnails because my instance is
no longer prepending the host URL to the location returned by the
storage object.

I can fix the issue of broken thumbnails for deleted media by inspecting
all locations returned by the storage object and guessing whether
they're local or remote with some regex (boo slow string operations).
But my question is this: Do we actually want to provide default
thumbnails for deleted media? Or better yet, do we even want to show
graveyard activities in the inbox?

-- 
ayleph