[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [GMG-Devel] Tags/Collections for batchaddmedia
From: |
Christopher Allan Webber |
Subject: |
Re: [GMG-Devel] Tags/Collections for batchaddmedia |
Date: |
Tue, 03 Nov 2015 16:40:06 -0600 |
Awesome, thanks for the patch!
Dan Krol writes:
> Okay, I'm guessing that the reason tags weren't added to batchaddmedia is
> that submit_media takes a string parameter for tag names rather than the
> corresponding tag objects. This means that submit_media would likely be
> querying for the same tags over and over again, which is very inefficient.
> So, it's maybe worth splitting out a function underneath submit_media that
> takes the tag objects, which submit_media calls on? Do you all have a
> recommended way to do this, that's in line with your code's organization? I
> assume just adding tag_objects and collection_objects parameters would
> muddy up submit_media's interface.
I think that should be possible. We could just add another keyword
argument to submit_media that takes tag objects.
> For my own purposes I can just do it the inefficient way for now, if
> there's not a great answer for this. Here's what it looks like at the
> moment (forked from v0.8.0 fo rnow), and it seems to work:
> https://github.com/orblivion/mediagoblin/compare/853b74cd813b3dea3ac351256b3ce1730664d7f9...batchaddmedia-collection-tag
Yay!
If you wanted to do the more efficient route, I'd quite happily accept a
patch/branch and merge it.
- [GMG-Devel] Tags/Collections for batchaddmedia, Dan Krol, 2015/11/01
- Re: [GMG-Devel] Tags/Collections for batchaddmedia, Dan Krol, 2015/11/03
- Re: [GMG-Devel] Tags/Collections for batchaddmedia,
Christopher Allan Webber <=
- Re: [GMG-Devel] Tags/Collections for batchaddmedia, Dan Krol, 2015/11/03
- Re: [GMG-Devel] Tags/Collections for batchaddmedia, Christopher Allan Webber, 2015/11/04
- Re: [GMG-Devel] Tags/Collections for batchaddmedia, Dan Krol, 2015/11/05
- Re: [GMG-Devel] Tags/Collections for batchaddmedia, Christopher Allan Webber, 2015/11/06
- Re: [GMG-Devel] Tags/Collections for batchaddmedia, Dan Krol, 2015/11/06
- Re: [GMG-Devel] Tags/Collections for batchaddmedia, Dan Krol, 2015/11/08
- Re: [GMG-Devel] Tags/Collections for batchaddmedia, Dan Krol, 2015/11/09
- Re: [GMG-Devel] Tags/Collections for batchaddmedia, Christopher Allan Webber, 2015/11/09
- Re: [GMG-Devel] Tags/Collections for batchaddmedia, Dan Krol, 2015/11/10
- Re: [GMG-Devel] Tags/Collections for batchaddmedia, Dan Krol, 2015/11/10