Re: [GMG-Devel] [PATCH] Fix #5315 - use `env` in shebangs

[Matt Molyneaux]

On Tue, 2016-01-12 at 10:14 +0100, Loic Dachary wrote:
> bash shebangs are changed to #!/usr/bin/env bash instead of
> /usr/bin/bash. That makes things work out of the box on systems
> where bash is not in /usr/bin, which is the case in all the BSDs and
> Solaris.
> 
> Signed-off-by: Loic Dachary <address@hidden>
> ---
>  bootstrap.sh                      | 2 +-
>  devtools/compile_translations.sh  | 2 +-
>  devtools/make_example_database.sh | 2 +-
>  devtools/maketarball.sh           | 2 +-
>  devtools/update_extlib.sh         | 2 +-
>  devtools/update_translations.sh   | 2 +-
>  6 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/bootstrap.sh b/bootstrap.sh
> index bc86670..e014748 100755
> --- a/bootstrap.sh
> +++ b/bootstrap.sh
> @@ -1,4 +1,4 @@
> -#!/bin/bash
> +#!/usr/bin/env bash
> 
>  set -e
> 
> diff --git a/devtools/compile_translations.sh
> b/devtools/compile_translations.sh
> index 398cb5c..6104892 100755
> --- a/devtools/compile_translations.sh
> +++ b/devtools/compile_translations.sh
> @@ -1,4 +1,4 @@
> -#!/bin/bash
> +#!/usr/bin/env bash
> 
>  # GNU MediaGoblin -- federated, autonomous media hosting
>  # Copyright (C) 2015 GNU MediaGoblin contributors.  See AUTHORS.
> diff --git a/devtools/make_example_database.sh
> b/devtools/make_example_database.sh
> index 7e857f5..7cca392 100755
> --- a/devtools/make_example_database.sh
> +++ b/devtools/make_example_database.sh
> @@ -1,4 +1,4 @@
> -#!/bin/bash
> +#!/usr/bin/env bash
> 
>  # GNU MediaGoblin -- federated, autonomous media hosting
>  # Copyright (C) 2011, 2012 GNU MediaGoblin Contributors.  See
> AUTHORS.
> diff --git a/devtools/maketarball.sh b/devtools/maketarball.sh
> index c6c2bc2..70a7b65 100755
> --- a/devtools/maketarball.sh
> +++ b/devtools/maketarball.sh
> @@ -1,4 +1,4 @@
> -#!/bin/bash
> +#!/usr/bin/env bash
> 
>  # GNU MediaGoblin -- federated, autonomous media hosting
>  # Copyright (C) 2011, 2012 GNU MediaGoblin Contributors.  See
> AUTHORS.
> diff --git a/devtools/update_extlib.sh b/devtools/update_extlib.sh
> index 52ac775..214fcce 100755
> --- a/devtools/update_extlib.sh
> +++ b/devtools/update_extlib.sh
> @@ -1,4 +1,4 @@
> -#!/bin/bash
> +#!/usr/bin/env bash
> 
>  # GNU MediaGoblin -- federated, autonomous media hosting
>  # Copyright (C) 2015 GNU MediaGoblin Contributors.  See AUTHORS.
> diff --git a/devtools/update_translations.sh
> b/devtools/update_translations.sh
> index 58e4e11..d04f4b3 100755
> --- a/devtools/update_translations.sh
> +++ b/devtools/update_translations.sh
> @@ -1,4 +1,4 @@
> -#!/bin/bash
> +#!/usr/bin/env bash
> 
>  # GNU MediaGoblin -- federated, autonomous media hosting
>  # Copyright (C) 2011, 2012 GNU MediaGoblin contributors.  See
> AUTHORS.
> -- 
> 2.6.4
> 
> 

Looks good to me, but I think I lost my commit rights when GMG moved to
Savannah.

signature.asc
Description: This is a digitally signed message part