[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [GMG-Devel] Want a new hook for a search plugin
From: |
Christopher Allan Webber |
Subject: |
Re: [GMG-Devel] Want a new hook for a search plugin |
Date: |
Wed, 24 Feb 2016 11:07:43 -0800 |
User-agent: |
mu4e 0.9.13; emacs 24.5.1 |
Great! I would love to see this get to a point where we can easily
merge.
At the moment I'm focused on this release so I can't make immediate
comment, but maybe it's something I can help look into post-release if
progress is being made. It would be easiest if you two would coordinate
on the best way forward though.
Tom Fay writes:
> There's a bit of similarity between the two, insofar as they both make
> a whoosh index and write documents to it...
>
> My code is currently working with the latest mediagoblin code, but
> doesn't work with 0.8.1 and earlier, as it relies on a couple of
> recent code changes. For example, on startup it uses the updated
> attribute of a MediaEntry to determine whether or not to re-index the
> entry.
>
> There was an existing issue on trac,
> https://issues.mediagoblin.org/ticket/960, so I've grabbed
> it. Praveen/Chris, if you have any questions or want to discuss this
> further then let's do it there. I'll look into adding a couple of more
> features, such as the ability to search for media by comments, and use
> celery to build the index on startup, before seeing if you want to add
> it to the core plugins.
>
> Cheers,
> Tom
>
> ---- On Tue, 19 Jan 2016 23:11:28 +0000 Christopher Allan Webber
> <address@hidden> wrote ----
> > Tom Fay writes:
> >
> > > Hi Praveen and Christopher,
> > >
> > > I did read Praveen's report, and but I couldn't find a working plugin
> > > in your repos so wrote a simple one. I'd have liked to use a backend
> > > agnostic library like haystack, but it's closely tied to django so I
> > > went with the same whoosh backend as Praveen. It only handles media
> > > entries, which is sufficient for me at the moment, but it does index
> > > existing entries. It's fairly well UT'd but hasn't had much testing:
> > > AFAIK it's only used by me on a tiny instance!
> > >
> > > Christopher: I probably don't need a new plugin (I'm just using the
> > > wrap_wsgi one at the moment, at which point the db and celery is
> > > already setup). I'll take a look at the overlap between the functions
> > > of mine and Praveen's.
> >
> > Great, look forward to seeing what comes out of it!
> >