mediagoblin-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GMG-Devel] [PATCH 1/3] Change API filename upload using custom header


From: Romain Porte
Subject: [GMG-Devel] [PATCH 1/3] Change API filename upload using custom header
Date: Sat, 11 Nov 2017 18:29:54 +0100

When uploading a file using the API its same is always going to be
'unknown.<extension>', which is not good looking for file urls. This
patch proposes a custom header named 'X-File-Name' that allows to
specify a file name using an API client.

This changeset was tested with a local OAuth1 client.
---
 mediagoblin/api/views.py | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/mediagoblin/api/views.py b/mediagoblin/api/views.py
index 74181fde..b25300f0 100644
--- a/mediagoblin/api/views.py
+++ b/mediagoblin/api/views.py
@@ -115,8 +115,13 @@ def uploads_endpoint(request):
             )
 
         mimetype = request.headers["Content-Type"]
-        filename = mimetypes.guess_all_extensions(mimetype)
-        filename = 'unknown' + filename[0] if filename else filename
+
+        if "X-File-Name" in request.headers:
+            filename = request.headers["X-File-Name"]
+        else:
+            filename = mimetypes.guess_all_extensions(mimetype)
+            filename = 'unknown' + filename[0] if filename else filename
+
         file_data = FileStorage(
             stream=io.BytesIO(request.data),
             filename=filename,
-- 
2.15.0



reply via email to

[Prev in Thread] Current Thread [Next in Thread]