[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Remove persona plugin (patch is attached)

From: Ben Sturmfels
Subject: Re: Remove persona plugin (patch is attached)
Date: Fri, 23 Apr 2021 17:58:30 +1000
User-agent: mu4e 1.4.15; emacs 27.2

Hi jgart,
On Tue, 20 Apr 2021, jgart wrote:

> Mozilla persona is RIP since 2016. See here:
> I think I got it all. I haven't tested this patch yet.
> What is your setup/workflow for testing mediagoblin?

Thanks for the patch, I think it makes sense to remove the persona
plugin. I've tested and merged this patch - see the master branch.

Development on Guix is still a bit in flux, but here's how I'd suggest
testing in future:

guix environment -l guix-env.scm
rm -rf bin include lib lib64 pyvenv.cfg
VIRTUALENV_FLAGS='--system-site-packages' ./configure

Then run the tests with:

bin/python -m pytest -rs ./mediagoblin/tests/ --boxed

That's a hybrid approach that uses Guix for the main dependencies, but
still installs a full virtualenv and downloads from PyPI. The
alternative approach of using an isolated container and avoiding PyPI is
documented in guix.scm.

> ps
> Also, what do you think of enabling the gitignore for python bytecode
> files since we don't need those in the directory and they will
> probably slow down the speed of cloning the repo?

I'm not sure I understand. MediaGoblin's .gitignore already includes
"*.pyc". I also just cloned a fresh copy of the repo to check that there
aren't already any "*.pyc" files and there aren't. Can you explain this
further please?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]