Re: [Mingw-cross-env-list] New Package: qwtplot3d

[Mark Brand]

On 08/31/2011 04:41 PM, Gareth Coco wrote:

Hi,

I use this in one of the applications I build up so thought I'd contribute it:

http://qwtplot3d.sourceforge.net/

QwtPlot3D is not a  program, but a feature-rich Qt/OpenGL-based C++
programming library, providing essentially a  bunch of 3D-widgets for
programmers

Gareth

Hi Gareth,

Thanks for your contribution. I have a few questions and comments about it.

The .mk file doesn't seem to install any headers.

I wonder if it would be better to start with version 0.3.0. It's not mentioned in the site's news, but is available for download.

At line 18 in the .pro file I see this:

# Comment the next line, if you have zlib on your windows system
win32:CONFIG -= zlib

Since mingw-cross-env supplies zlib, shouldn't you comment that out?

I think it would be better to use patches instead of sed operations, so it's easier to see which changes still fit when upgrading to the next version.

One last nitpick: Your including of cstdio looks like a mingw compatibility issue. That should be done with #ifdef/#endif and the patch should be submitted upstream.

Mark