Re: [Mingw-cross-env-list] Why BOOST_USE_WINDOWS_H defined by default in MXE patch?

[Tony Theodore]

Welcome Arseniy,

On 24 Dec 2015, at 12:40, Arseniy Shestakov <address@hidden> wrote:

Hello,

I recently find out about MXE and start using it for project I work on. In process I'm got multiple conflicts with constant and struct names that didn't happen for other developer. More details available there:

http://forum.vcmi.eu/viewtopic.php?t=1122

I'd recently back to it and find out that reason of conflicts was BOOST_USE_WINDOWS_H set by default in MXE boost patch: https://github.com/mxe/mxe/blob/a8df43d1324294522bde66f2c5d5f9f6d43476e6/src/boost-1-fixes.patch

Then I get rid of that part of patch and successfully built everything without BOOST_USE_WINDOWS_H and it's worked fine for me. I tried to find out why that was needed, but didn't manage to find any details on github.

So I now wonder why BOOST_USE_WINDOWS_H was needed in interlocked.hpp? Is it still needed?

Mingw-w64 has since been updated so it’s possible that isn’t needed anymore. Boost is also due for an update [1] and the latest version seems to require less patching so far - that patch is one that’s been removed.

Cheers,

Tony

[1] https://github.com/tonytheodore/mxe/commit/fdd5b9f7aa8bf0e40c1f1f8119701af96e51457e