[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Mldonkey-users] Sha1 implementation benchmark
From: |
Fortin Denis |
Subject: |
[Mldonkey-users] Sha1 implementation benchmark |
Date: |
Wed, 04 Feb 2004 20:19:12 +0100 |
I've added another implementation of sha1 hash. It's
written by Brian Gladman and can be found here :
http://fp.gladman.plus.com/cryptography_technology/sha/index.htm
Before everything else i would like to make sure that the licence is ok
for mldonkey.
Copyright (c) 2002, Dr Brian Gladman, Worcester, UK. All rights
reserved.
LICENSE TERMS
The free distribution and use of this software in both source and
binary
form is allowed (with or without changes) provided that:
1. distributions of this source code include the above copyright
notice, this list of conditions and the following disclaimer;
2. distributions in binary form include the above copyright
notice, this list of conditions and the following disclaimer
in the documentation and/or other associated materials;
3. the copyright holder's name is not used to endorse products
built using this software without specific written permission.
ALTERNATIVELY, provided that this notice is retained in full, this
product
may be distributed under the terms of the GNU General Public License
(GPL),
in which case the provisions of the GPL apply INSTEAD OF those given
above.
DISCLAIMER
This software is provided 'as is' with no explicit or implied
warranties
in respect of its properties, including, but not limited to,
correctness
and/or fitness for purpose.
---------------------------------------------------------------------------
I find this a little strange : "provided that this notice is retained in
full"
Is it ok? (is it ok for debian Sylvain?)
If the licence is ok, here's my plan :
1) Check if it works flawlessly on major platforms (Little/Big-endian,
Linux/Macos/Windows, cpu family ...)
If it doesn't work for some platform and if the user reporting this
failure can't fix the bug, i'll stop this experience here (i don't want
to mess with those files)
2) If no one see a severe degradation in performance i'll submit a clean
patch removing the old implementation.
To test this:
make sha1bench
./sha1bench a_file
or ./sha1bench -r x a_file to repeat x times the hashing function
About the output :
RFC, is what we have now in mldonkey. This is used as a reference.
If after this line "Testing Brian Gladman's implementation" you see
a 'X' instead of '.' then the output of the new sha1 hash is wrong.
For me it's 30 to 50% faster than RFC
Denis Fortin
sha1bench.patch
Description: Text document
- [Mldonkey-users] Sha1 implementation benchmark,
Fortin Denis <=
- Re: [Mldonkey-users] Sha1 implementation benchmark, kami petersen, 2004/02/04
- Re: [Mldonkey-users] Sha1 implementation benchmark, Fortin Denis, 2004/02/04
- [Mldonkey-users] Bug in Overnet source handling causes being banned, mldonkey, 2004/02/06
- Re: [Mldonkey-users] Bug in Overnet source handling causes being banned, Pierre Etchemaite, 2004/02/06
- Re: [Mldonkey-users] Bug in Overnet source handling causes being banned, mldonkey, 2004/02/06
- Re: [Mldonkey-users] Bug in Overnet source handling causes being banned, Pierre Etchemaite, 2004/02/06
- Re: [Mldonkey-users] Bug in Overnet source handling causes being banned, mldonkey, 2004/02/07
[Mldonkey-users] Re: Sha1 implementation benchmark, spiralvoice, 2004/02/04