[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Monotone-devel] Re: ViewMTN 0.01

From: Bruce Stephens
Subject: [Monotone-devel] Re: ViewMTN 0.01
Date: Sat, 30 Apr 2005 21:46:03 +0100
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux)

address@hidden (Grahame Bowland) writes:


> If a revision is signed with multiple branches it should end up
> showing multiple branches at once? I'm not quite sure what it does
> in this case!

I presume it'll end up in multiple branches.  I was assuming that
propagates would produce a revision somewhat like merges, so the
structure would show the revision having two ancestors.  But it
doesn't: if you want to know, you have to interpret the changelog.  So
that's simpler than I thought.

>> I think it would be nice to show arrowheads (because this is a
>> directed graph), and maybe show merges differently (as monotone-viz
>> does).  However, those two are really minor, IMHO.
> I've changed it to be a directed graph, and the revision we're
> determining the ancestry of is now shown in blue. I'll look into
> showing branches differently, thanks for the suggestion :-)

Ah, but now the graph is up the other way, with the heads at the
bottom.  That's consistent with the way monotone-viz does it, which is
good.  But it means that I (often) have to scroll to see the head
which the changelog refers to.

I'm not sure what the right thing to do is.  It's simple to reverse
things, if that seems better (but I'm not sure if it is):

# patch ""
#  from [428483fe538c6687671cdd2dd64841f217037a25]
#    to [f87f406a1cc397adeddb23c04613efdc1c9542ae]
@@ -149,6 +149,7 @@
                        rv['cached'] = True
                        return rv
                contents = "digraph ancestry {"
+               contents += "edge [dir=back];\n"
                revisions = sets.Set()
                for attrs in self.ancestry(id, limit):
                        if not attrs.has_key("Revision") or not 
@@ -158,7 +159,7 @@
                        for ancestor in attrs['Ancestor']:
                                if len(ancestor) == 0: continue
-                               contents += '"%s"->"%s"\n' % (ancestor, 
+                               contents += '"%s"->"%s"\n' % (revision, 
                for revision in revisions:
                        opts = 'fontsize=8,shape=box,href="revision.psp?id=%s"' 
% (urllib.quote(revision))
                        if revision == id: opts += ",color=blue"

reply via email to

[Prev in Thread] Current Thread [Next in Thread]