[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Monotone-devel] Re: [PATCH] parent selector 'p:xxx'

From: Ethan Blanton
Subject: Re: [Monotone-devel] Re: [PATCH] parent selector 'p:xxx'
Date: Mon, 8 Oct 2007 10:52:13 -0400
User-agent: Mutt/1.5.13 (2006-08-11)

Lapo Luchini spake unto us the following wisdom:
> Ethan Blanton wrote:
> > Even when it is correct, for
> > Pidgin it often has 3-5 parallel lines at two columns apiece, and
> > often it mistakenly draws O(a lot) of parallel lines.
> BTW: As far as correctness goes, I think it is correct.
> The "problem" is it is usually run on a restricted set of nodes and
> proper use of "daggy fixes" lead to merges with very old nodes (and thus
> very long arcs in the overall DAG).

In this case, correct is in the eye of the beholder.  It might be
technically correct, but still be presenting useless information which
makes it functionally incorrect.

As an example, if I log only a dozen revisions, and there is only one
divergence and merge within those dozen revisions, there should be no
more than two lines -- but sometimes there will be tens of lines from
the first revision to the very last, representing (I presume) parallel
and unrelated divergences.  I think Richard Levitte sent an example of
this to the list, some time back.

That said, there are places in the Pidgin history where the graph code
shows tens of parallel revisions, where monotone-viz shows two or
three -- they can't both be right, if they are both displaying the
same data.  ;-)


The laws that forbid the carrying of arms are laws [that have no remedy
for evils].  They disarm only those who are neither inclined nor
determined to commit crimes.
                -- Cesare Beccaria, "On Crimes and Punishments", 1764

Attachment: signature.asc
Description: Digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]