[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Monotone-devel] Re: colored diffs [Was: [PATCH] parent selector 'p:

From: Nathaniel Smith
Subject: Re: [Monotone-devel] Re: colored diffs [Was: [PATCH] parent selector 'p:xxx']
Date: Mon, 8 Oct 2007 17:05:53 -0700
User-agent: Mutt/1.5.13 (2006-08-11)

On Mon, Oct 08, 2007 at 08:32:45PM +0100, Zack Weinberg wrote:
> It's a good idea but you need to be careful how you implement it.
> Hardwiring VT220 color control codes would be bad.  So would making us
> depend on ncurses.
> I'd suggest a set of Lua hooks that know the necessary escape
> sequences for the most common TERM= settings (xterm, etc) and can
> query the 'tput' utility for less common ones.  You could also use
> this to get at the line-drawing characters for
> asciik...

Before going this route, could you expand on "hardwiring VT220 color
control codes would be bad"?  Are there any terminals we actually care
about that this would fail on?  (Note that the grep and ls maintainers
have both answered "no" to this question; search for the string '33['
in their source code.  ls at least appears to also have a whitelist
of $TERM values that are colorizable, dunno about grep.)

-- Nathaniel

Eternity is very long, especially towards the end.
  -- Woody Allen

reply via email to

[Prev in Thread] Current Thread [Next in Thread]