Re: [Monotone-devel] [PATCH] Make "mtn log" show the signer of changelog/comment certs

[Richard Laager]

On Sat, 2008-01-05 at 15:22 -0500, Hugo Cornelis wrote:
> Any chance this patch can be extended such that
> 
> 1. the signers of all certs are shown,

I didn't do this for two reasons. First, I didn't have a need to see who
issued an "Author" or "Date" cert. Second, showing that will take up
more room. It's easy to fit the signer when it's a multiline cert, but
not so easy when it's on one-line.

> 2. yet, only when an appropriate command line option has been given.

> Point 2 is about ease of use and avoiding confusing: for single person
> repositories, don't show what is redundant.

I had initially wanted to show the signer only if it differed from the
author. That would be possible, but it requires the following extra
logic:

1. Get all the author certs. (To do this efficiently, we'd want to get
them once per-revision, not in each call to log_certs.)
2. If there is exactly one author cert, compare its value to the signer
of the other cert (that we're displaying). If not equal, show the
signer.

Doing this extra work (both in terms of coding and more importantly, in
terms of run-time work) didn't seem useful to me, given that always
showing the signer isn't really harmful.

Richard

signature.asc
Description: This is a digitally signed message part