[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Monotone-devel] automate get_current_revision [was --non-interactiv
Re: [Monotone-devel] automate get_current_revision [was --non-interactive ... ]
Wed, 20 Feb 2008 11:02:35 +0100
2008/2/20, Thomas Keller <address@hidden>:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> Zbigniew Zagórski schrieb:
> > 31-01-08, Zbigniew Zagórski <address@hidden> napisał(a):
> >> Thomas Keller wrote:
> >> ...
> >> >
> >> > On a related note, if you think of doing commits over automate like
> >> > I currently do, what is really _lacking_ in automate is a way to
> >> let > mtn
> >> > return a valid restricted revision for a given set of paths (i.e. I
> >> > currently just feed put_revision with the complete output of
> >> > get_revision). One could of course do the node restriction logic in
> >> > the client (f.e. for renames), but this is very ugly.
> >> How about adding:
> >> automate get_current_revision [PATHS...]
> >> Which will return current workspace revision restricted with PATHS.
> >> Now when automate commands can accept options it will be possible to
> >> add --depth and --exclude options also.
> > Hi,
> > I've commited f6cb000f1bbcf35e6458c5e62e10ecef02021752 with
> > implementation of this command. Please review if worried about quality
> > ;) (tests/doc/NEWS).
> > Best regards,
> Heh... I totally forgot about that thread, and that there is already an
> implementation for get_current_revision sitting in
> nvm.automate_current_revision (for quite some time) - but this is not a
> problem. I'll review your version and we'll take just that. If
> everything is ok, I'll suspend the old branch.
Hmm, sorry for mess i didn't know about that branch. Lot of
interesting things are hidden there in nvm....
Looking at differences:
1. Your version fails if there are no changes in workspace. Dunno if
it's good or not. (after few minutes of thinking it's rather good).
2. I think it's reasonable to limit functionality of get_revision to
give only revisions form database. (automate_get_revision test needs
to be updated)
3. Code is almost the same ... looks like we copy-pasted from same source ;)
4. I'm curious if your code will pass my unittest...
I think that if we merge both revs the result will be interesting and usable.
I can do it this evening ...
/ software developer / geek / happy daddy /