Re: [Monotone-devel] ikiwiki monotone support

[Brian May]

>>>>> "William" == William Uther <address@hidden> writes:


    >> if (defined($config{mtnsync}) && $config{mtnsync}) { +
    >> check_mergerc(); if (system("mtn",
    >> "--root=$config{mtnrootdir}", "sync", - "--quiet",
    >> "--ticker=none", + "--quiet", "--ticker=none", "--rcfile",
    >> $config{mtnmergerc}, "--key", $config{mtnkey}) != 0) {
    >> debug("monotone sync failed before update");
    >> }

    William> Not sure that bit is required.  I was just going through and adding
    William> the -rcfile arg to everything so that if more got added
    William> there in future it wasn't confusing that it was only
    William> being referenced in some places.

 190 sub rcs_update () { #{{{
 191         check_config();
 192 
 193         if (defined($config{mtnsync}) && $config{mtnsync}) {
 194                 if (system("mtn", "--root=$config{mtnrootdir}", "sync",
 195                            "--quiet", "--ticker=none", 
 196                            "--key", $config{mtnkey}) != 0) {
 197                         debug("monotone sync failed before update");
 198                 }
 199         }
 200 
 201         if (system("mtn", "--root=$config{mtnrootdir}", "update", 
"--quiet") != 0) {
 202                 debug("monotone update failed");
 203         }
 204 } #}}}

I can't help but feel this seems wrong.

In particular, it might be better without the mtn sync.

Presumably, rcs_update will be called automatically after a "mtn pull"
has occurred, by the hook, making this redundant.

Also, having rcs_update do a mtn push operation just seems wrong to
me. The push occurs after a commit...

The "mtn update" seems fine though. Assuming there aren't multiple
branches...
-- 
Brian May <address@hidden>