[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Monotone-devel] commit ignores _MTN/options keydir
From: |
Stephen Leake |
Subject: |
Re: [Monotone-devel] commit ignores _MTN/options keydir |
Date: |
Sat, 08 Mar 2008 16:33:29 -0500 |
User-agent: |
Gnus/5.1006 (Gnus v5.10.6) Emacs/22.1 (windows-nt) |
Derek Scherger <address@hidden> writes:
> Stephen Leake wrote:
>> Derek Scherger <address@hidden> writes:
>> I think deleting that invariant check is the best fix. There is
>> nothing the in contract for get_ws_options that says 'opts' must be
>> empty before it is called; it just overrides the values in opts that
>> come from the _MTN/options file.
>
> Yeah, I think that the invariant should probably be removed. Any objections?
>
>> Deleting the similar check in dbname also makes sense.
>
> Seems reasonable to me.
I did not delete that in my first fix, just to make minimal changes.
But now I've hit that invariant when doing 'mtn propagate', so I'll
delete it.
Which means the test suite should not specify --db unless actually
needed, in addition to treating --keydir that way.
--
-- Stephe
Re: [Monotone-devel] commit ignores _MTN/options keydir, Stephen Leake, 2008/03/05
Re: [Monotone-devel] commit ignores _MTN/options keydir, Stephen Leake, 2008/03/15