[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Monotone-devel] Re: [PATCH 1/2] git_export: avoid multiple sql queries

From: Derek Scherger
Subject: [Monotone-devel] Re: [PATCH 1/2] git_export: avoid multiple sql queries
Date: Sun, 8 Mar 2009 21:41:40 -0600

On Sat, Mar 7, 2009 at 11:31 PM, Felipe Contreras <address@hidden> wrote:
This improves performance while exporting. In my system I see an
improvement from 52 minutes to 6 seconds.

Committed in rev 0d53349ddb2728ddf1342cdfe69810840bef5252. I've also done something similar to the log command and this made a *huge* difference. On my laptop logging net.venge.monotone back to the root took around 9 minutes. With this change it takes around 4 seconds.

The problem that this has uncovered seems to be that the query for certs by revision id and name uses the unique index on revision_certs which isn't the one we want. Querying without the name uses the revision id index which seems to be much better.

Thanks Felipe!


reply via email to

[Prev in Thread] Current Thread [Next in Thread]