nano-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Nano-devel] ready for testing: nano-1.3.8pre2


From: David Lawrence Ramsey
Subject: Re: [Nano-devel] ready for testing: nano-1.3.8pre2
Date: Tue, 28 Jun 2005 20:33:04 -0400
User-agent: Mozilla Thunderbird 1.0.2 (X11/20050317)

Mike Frysinger wrote:

<snip>

>nope ... the current one suffers from the same issue ... only
>difference is the memory that is being clobbered has moved ;)

I suppose that's progress ;)

>void do_gotolinecolumn(int line, ssize_t column, bool use_answer
>...
>    if (!parse_line_column(answer, &line, &column) || line < 1 ||
>...
>
>so you're prob clobbering the column memory on the stack

It looks that way.  Thanks again for the help tracking this down.  That
"int line" should be "ssize_t line", both there and in proto.h.  I just
fixed it in CVS.  Does it work now?

>>I do that because strncmp(s1, s2, (size_t)-1) should be equivalent to
>>strcmp(s1, s2).  Both of them stop running once they encounter a
>>differing character and/or a null terminator in either the first or both
>>strings (cf. glibc CVS, uClibc CVS, nstrcasecmp() and nstrncasecmp() in
>>chars.c), so there shouldn't be any problem, since both strings are
>>properly null-terminated.
>
>fair enough ... HTB checks the arguments when the func is first called
>rather than seeing if the func misbehaves in the process ...

Ah, so it's just being paranoid.  That's probably a good thing...





reply via email to

[Prev in Thread] Current Thread [Next in Thread]