[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Nano-devel] one more undo failure

From: Benno Schulenberg
Subject: Re: [Nano-devel] one more undo failure
Date: Sat, 21 Jun 2014 22:29:05 +0200

Hi Mark,

On Sat, Jun 21, 2014, at 17:52, Mark Majeres wrote:
> Yes, undoing/redoing some actions, such as cut/paste/file insert will
> mark a selection prior to calling do_cut.  IMO, editing the file while
> an area is marked/selected is a strange thing to do.

But people do strange things, and it is something that I would do:
while busy selecting an area I want to move, I see a word I want
to change, I will do that, and then proceed to make the selection.
Having the mark on does not bother me.

Thus, undoing the word change should not unset the mark unless
absolutely necessary to make the undo work properly.

> I don't think
> anyone will expect anything less.  Unmarking before undo/redo only
> some of the time would be inconsistent.

Hm.  Maybe some more unsettings of the mark can be left out?

By the way, in redo_cut() there is a free(cutbuffer).  Shouldn't
that be a free_filestruct(cutbuffer), like in undo_cut()?

And the lines around there, fiddling witj openfile->mark_set,
would it be nicer to regroup these as:

    if (!ISSET(CUT_TO_END))
        openfile->mark_set = TRUE;
        openfile->mark_set = u->mark_set;
    openfile->mark_begin = fsfromline(u->mark_begin_lineno);
    openfile->mark_begin_x = (u->xflags == UNcut_cutline) ? 0 : u->mark_begin_x;


-- - Email service worth paying for. Try it for free

reply via email to

[Prev in Thread] Current Thread [Next in Thread]