nano-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Nano-devel] [PATCH] browser: fix handling of large files


From: Mike Frysinger
Subject: Re: [Nano-devel] [PATCH] browser: fix handling of large files
Date: Wed, 15 Jul 2015 22:00:54 -0400

On 15 Jul 2015 20:45, Benno Schulenberg wrote:
> On Wed, Jul 15, 2015, at 12:31, Mike Frysinger wrote:
> > +       if (modifier != 'G' || result < (1 << 10))
> > +           sprintf(foo, "%4ju %cB", (intmax_t)result, modifier);
> 
> The "modifier != 'G'" isn't needed, I think;  "if (result < (1 << 10))"
> should be enough, no?

it might be.  i didn't want to think too hard about the bit shifts and the 
different cases :).
-mike

Attachment: signature.asc
Description: Digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]