Re: [Nano-devel] [PATCH] bug #48305: allow any kind of separator in "Go To Line"

[Benno Schulenberg]

On Mon, Jul 4, 2016, at 16:06, Rishabh Dave wrote:
> On Mon, Jul 4, 2016 at 6:00 PM, Benno Schulenberg
> <address@hidden> wrote:
> > Patch is not simple enough.  You don't need the variable 'accept'.
> >
> > When you've got rid of it, sign off your patch.
> 
> Yes. Replaced 'accept' where it was used by the literal itself.

Right.

> Also, replaced comma by separator.

No, that is not what I wanted.  Don't rename things when
you make changes in the logic.

Also, in the commit message explain the reason of the change,
the reason for allowing these other separators.

> >  But if your /etc/nanorc file doesn't do it, then
> > do 'include /usr/share/nano/patch.nanorc' in your ~/.nanorc.
> 
> Exactly what I did.

Ah.  Then compare your /usr/share/nano/patch.nanorc with
doc/syntax/patch.nanorc.  The must be different.

If you made a local install of nano from git, then include
/usr/local/share/nano/patch.nanorc instead.  Do the same
for other syntaxes you need, and remove all includes from
/etc/nanorc.

> > ??  Nano's patch syntax does not show green blocks where there
> > is no trailing whitespace.
> 
> Not trailing whitespace but it shows green block in first column on
> lines separating two blocks of code (like attached patch has one among
> many at line 24).

Zero green blocks here in your patch.

Benno

-- 
http://www.fastmail.com - Send your email first class