[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Nano-devel] [PATCH] toggle for the key rebound in rcfile is uniniti

From: Benno Schulenberg
Subject: Re: [Nano-devel] [PATCH] toggle for the key rebound in rcfile is uninitialized
Date: Fri, 05 Aug 2016 10:35:05 +0200

On Thu, Aug 4, 2016, at 19:51, Rishabh Dave wrote:
> Link to the bug -
> Logic behind attached patch: if there is same shortcut already in the
> shortcut list, then assign same toggle value to the key rebound, 

But... this is strange!  Why would toggle need to be assigned a value?
If it didn't already have the correct value, it would mean that rebinding
toggles wouldn't be working at all (or not correctly) without your patch.
But things work.  It is in fact your patch that breaks things.  Try this
at the end of your nanorc:

unbind M-C all
bind M-C nohelp main
bind M-C nextword main
bind M-C whitespacedisplay main

Now guess what M-C does in the edit window?  Then remove the last
line and try again.  Strange, huh?  Not what we want.

When there's an unitialized value, all it needs is to initialize the value.
That requires a single instruction, one assignment, in the right place,
and that is not in src/rcfile.c.  Try again.


-- - A fast, anti-spam email service.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]