[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Nano-devel] [PATCH] add rebinding for Ctrl+Arrow-keys combinations

From: Rishabh Dave
Subject: Re: [Nano-devel] [PATCH] add rebinding for Ctrl+Arrow-keys combinations
Date: Fri, 26 Aug 2016 18:47:48 +0530

On Wed, Aug 24, 2016 at 1:23 PM, Benno Schulenberg <address@hidden> wrote:
> Looks good.  But you don't need the parentheses around the
> first \^ because it has no alternative.  And it would be nicer
> to write Up etcetera with an capital, just like Ins and Del,
> and for consistency then also the one relevant Space.

Okay, first letters of up, down, right, left and space are capitalized in attached patch.

> Also, the rebinding code was incomplete -- see attached patch.

Oh! I completely forgot about editing the code for console. And didn't know enough to know the other change (relocating "s->keycode = keystring[1] - 64;")

> There are no translated manuals or Info docs for nano.  There are
> some old French man pages -- as you would know if you had browsed
> the doc/ subdir -- but nothing for any other language.  There is
> a feature request for that:

So... translations are only for statusbar messages. How can I switch language in that case too?

To check if all the code applies smoothly to master after pull, I did a checkout followed by pull and putting all code together (yours as well). and then I spent some time testing it. Attached is that patch. However, I don't what next: most of the issue are solved except the translating few key in help.

About translating Home, End, PgUp and PgDn, for once I thought we can we use ⭰,  ⭲, ⭱, and ⭳ for Home, End. Pgup, Pgdn? But then I think it is easy to relate function of Home to ⭰ but not vice versa. And Pgup ⭱ looks much nicer than in the case of Home and ⭲.

We can also draw the buttons literally. They will be only 7 spaces wide but 3 line height. Below is an example (looks little clattery on my side, but it looks better on terminal).

┃  ⭡  ┃

┃Home ┃

Not really good... but an option.

Attachment: rebinding-final.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]