nano-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Nano-devel] [PATCH] add rebinding for Ctrl+Arrow-keys combinations


From: Rishabh Dave
Subject: Re: [Nano-devel] [PATCH] add rebinding for Ctrl+Arrow-keys combinations
Date: Sun, 4 Sep 2016 21:59:48 +0530

On Thu, Sep 1, 2016 at 1:48 AM, Benno Schulenberg
<address@hidden> wrote:
>
> On Tue, Aug 30, 2016, at 20:12, Rishabh Dave wrote:
>> Okay. Patch is attached.
>
> Patch is incomplete, and no longer applies.  You forgot
> to do 'git pull' before working with the repo.  Things
> changed three days ago.
>
>> I have mentioned capitalization of first
>> letter of space as this change doesn't suit the subject line.
>
> The commit message is far too detailed.  It mentions details
> of the implementation, but that is what the patch itself is for.
> If anything needs to mentioned, it is the reason for making
> those key combos rebindable.  The above is a minute detail
> not worthy of mention.
>
> Also, it should refer to the bug number.
>
> Benno
>
> --
> http://www.fastmail.com - A no graphics, no pop-ups email service
>

Okay, patch is attached. Please tell me if it is fine. If so, I will
attach it to the bug too.

Attachment: 0001-feature-make-rebinding-Ctrl-arrow-key-possible.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]