Re: [Nano-devel] Nano with Line Numbering

[Benno Schulenberg]

On Thu, Sep 15, 2016, at 12:11, Faissal Bensefia wrote:
> Should all be fixed now. The new patch is attached.

Thanks.  Things are getting better and the patch is
getting smaller.  Great!

I've rebased your patch to current git, have added two
comments and have moved intlen() to utils.c.  See attached.


However, try this:
  stty cols 15 && src/nano --ignore --nowrap --linenum +5,22 NEWS
Floating-point error.

Further, try this:
  stty cols 44 && src/nano --ignore --soft --linenum +1 README.GIT
See how at least two lines at the bottom seem to be missing.
Do a PageDown and a PageUp.  See how those "missing" lines are
now occupied by lines that shouldn't be there.

But most of all, in softwrap mode, the continuation lines shouldn't
have a line number in front of them.  Look how vim handles this.
Run 'stty cols 44 && vim README.GIT', then type ":set nu" and see
how the continuation parts are numberless.  In nano, things should
look the same.

Benno

-- 
http://www.fastmail.com - Faster than the air-speed velocity of an
                          unladen european swallow

0001-Working-toward-line-numbering-seven.patch
Description: Text Data