[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Nano-devel] [PATCH] several ASCII characters from 64 to 127 cannot
|
From: |
Rishabh Dave |
|
Subject: |
Re: [Nano-devel] [PATCH] several ASCII characters from 64 to 127 cannot be rebound but are accepted without protest |
|
Date: |
Tue, 20 Sep 2016 23:01:34 +0530 |
Attached patch fixes all -- not wrapping, changing numbers instead of
operators in if statement, colouring M-`, M-~ and M-@ in green, not
colouring Ctrl combinations of ASCII symbols below 65 in green and
removing extra "0-9" from unbind line as well.
On Tue, Sep 20, 2016 at 2:55 PM, Benno Schulenberg
<address@hidden> wrote:
>
> On Sun, Sep 18, 2016, at 14:45, Rishabh Dave wrote:
>> Attached patch disallows rebinding of ^@, ^[, ^{, ^|, ^}, ^~, ^`
>
> - (keycopy[0] == '^' && ((keycopy[1] < 64 || keycopy[1] > 127)
> ||
> + (keycopy[0] == '^' &&
> + ((keycopy[1] <= 64 || keycopy[1] >= 123) ||
> + keycopy[1] == 91 || keycopy[1] == 96 ||
>
> Why change the operator (from < to <=)? Changing just the numbers
> would be clearer. And don't change the wrapping on that line --
> there is no need.
>
> Benno
>
> --
> http://www.fastmail.com - IMAP accessible web-mail
>
0001-rcfile-reject-several-ASCII-symbols-from-64-to-127.patch
Description: Text Data