[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Nano-devel] [PATCH] enable searching (^W) in a help text (^G)

From: Rishabh Dave
Subject: Re: [Nano-devel] [PATCH] enable searching (^W) in a help text (^G)
Date: Mon, 5 Dec 2016 14:26:11 +0530

On Sat, Dec 3, 2016 at 5:00 PM, Benno Schulenberg
<address@hidden> wrote:
>> Optimization was only complementary, but mainly I wrote it for a bug.
>> Do this without the patch applied
> You found a bug in unpatched nano?  Then please report it.

Sorry, made a mistake. Apply "wont-rewrap.patch" patch on top of the
current patch (it only removes all "76 business" related code). And
try that again. I have tested too for assurance.

>> > Don't bother with
>> > optimizations, just always recreate the help-text temp file when
>> > the window is resized.  It makes things easier to understand.
>> Well you confuse me. Sometimes you want optimization and sometimes not.
> Where did I promote optimization at the cost of complication?

Hmm... Then I missed something in previous optimizations; will look
more closely next time onwards.

> With your patch applied, run 'LANGUAGE=en src/nano --ignore --smooth',
> then type: ^G M-/ ^W help <Enter> M-W M-W M-W M-W...
> See how the cursor jumps alternatingly from top line to bottom line.
> That is not the normal nano behavior for offscreen matches.
> (Strangely this only happens when the end of the buffer has been
> displayed, after an M-/ or multiple ^Vs.)

Oh... Got it. foucsing is set to TRUE the beginning of every iteration
of do_help's while loop.

Attachment: 0001-new-feature-add-search-facility-to-help.patch
Description: Text Data

Attachment: wont-rewrap.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]