[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Nano-devel] proposal to add support for the XDG base directory spec
From: |
Simon Ochsenreither |
Subject: |
Re: [Nano-devel] proposal to add support for the XDG base directory spec |
Date: |
Sat, 21 Oct 2017 13:29:55 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
Hi everyone,
sorry for the messy patch earlier.
>> - migrates .nano/search_history to $XDG_DATA_HOME/nano/search_history
>> - migrates .nano/filepos_history to $XDG_DATA_HOME/nano/position_history
>
> No. I want a tool to do what I asked it to do, not to "helpfully"
> do things. This migration stuff was deleted from nano the moment
> that you suggested to add the XDG stuff. Don't bring it back in.
Sorry, I didn't see the changes, looks like I was a single commit behind
when I started working. :-/
> How nano should work is: if ~/.nanorc exists, use it. Otherwise,
> check the XDG paths. If ~/.nano/ exists, use it for both strings
> and positions histories. If it does not exist, try the XDG paths,
> and create it if it's missing.
Done.
> So, please remove all migration machinery from your patch.
Done.
> The calls of create_xdgdata...() are identical, so they can be moved
> out of the if -- calling free() on NULL is not an error. Doing it
> that way means there is no need for splitting have_dotnano() into
> two functions.
Done.
> Also, please leave out any DEBUG stuff. And if you can resist, don't
> change comments either. Only change the things that you need to change
> in order to make the patch *work*. All the rest is cosmetics and can
> be adjusted in subsequent patches.
Done.
Please have a look at the updated patch and tell me what you think!
Thanks,
Simon
xdg-support.patch
Description: Text Data
- Re: [Nano-devel] proposal to add support for the XDG base directory spec, (continued)
- Re: [Nano-devel] proposal to add support for the XDG base directory spec, Benno Schulenberg, 2017/10/07
- Re: [Nano-devel] proposal to add support for the XDG base directory spec, Brand Huntsman, 2017/10/07
- Re: [Nano-devel] proposal to add support for the XDG base directory spec, Benno Schulenberg, 2017/10/08
- Re: [Nano-devel] proposal to add support for the XDG base directory spec, Brand Huntsman, 2017/10/08
- Re: [Nano-devel] proposal to add support for the XDG base directory spec, Simon Ochsenreither, 2017/10/10
- Re: [Nano-devel] proposal to add support for the XDG base directory spec, Benno Schulenberg, 2017/10/11
- Re: [Nano-devel] proposal to add support for the XDG base directory spec, Brand Huntsman, 2017/10/11
- Re: [Nano-devel] proposal to add support for the XDG base directory spec, Mike Scalora, 2017/10/12
- Re: [Nano-devel] proposal to add support for the XDG base directory spec, Simon Ochsenreither, 2017/10/15
- Re: [Nano-devel] proposal to add support for the XDG base directory spec, Benno Schulenberg, 2017/10/17
- Re: [Nano-devel] proposal to add support for the XDG base directory spec,
Simon Ochsenreither <=
- Re: [Nano-devel] proposal to add support for the XDG base directory spec, Benno Schulenberg, 2017/10/24
- Re: [Nano-devel] proposal to add support for the XDG base directory spec, Simon Ochsenreither, 2017/10/27
- Re: [Nano-devel] proposal to add support for the XDG base directory spec, Benno Schulenberg, 2017/10/28