[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Nano-devel] [PATCH] Implement incremental search v3

From: Benno Schulenberg
Subject: Re: [Nano-devel] [PATCH] Implement incremental search v3
Date: Sat, 11 Nov 2017 18:23:07 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0

Op 10-11-17 om 22:38 schreef Marco Diego Aurélio Mesquita:
Attached patch is the same as the previous one. Just rebased it to current master.

Hope it is still on time to make it to 2.9.0.

No, you have misunderstood.  Most likely the patch will not be
applied at all.  And certainly not in its current form.

You see: when you toggle Incremental on, the previous search
string stays shown between square brackets.  But when searching
incrementally a previous search string does not make sense --
it should be cleared.  Typing <Enter> at an Incremental Search
prompt should do nothing.  It should return to the edit window
with the cursor position unchanged.

A further oddity is that when the incremental search fails,
nano just shows some file position, with nothing highlighted
and no indication that the search failed.  For example, run
'src/nano --smooth +44 NEWS' and type <Down> until the cursor
is on the line with "Axat", and then type: ^W M-I seven.  The
screen returns to where the cursor was, but with the "Axat"
line centered.  It is unclear what has happened.

When the last typed character does not yield a findable string,
the routine should beep, and not move from where the last occurrence
was found.  Best would probably be to not add the failing character
to the answer at the prompt, so the user does not need to delete
it first before typing something else or backspacing over earlier

And M-W should work at the Incremental Search prompt, to push
the highlight to the next occurrence, just like ^G works in
Firefox without first leaving the search bar.

But even if you fix all that, I'm not saying that the patch
would be applied.  I will test it again and see how I like it.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]