[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Nano-devel] [PATCH] Some improvements
From: |
Benno Schulenberg |
Subject: |
Re: [Nano-devel] [PATCH] Some improvements |
Date: |
Sat, 9 Dec 2017 18:04:55 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 |
About the second patch: why does coloring of preprocessor directives now
require two color statements? And statements that are nearly identical at
that. Why can't it be done with one of them?
Amended.
The new version does not color a lonely #else or #endif.
Also, it is a drain on resources: opening a large C file now takes twice
as long. The precalculation of the color info takes roughly five times as
long as for the disabled coloring of multiline strings. It was disabled
to avoid irritating slowdowns. So, I don't think we can do the multiline
regexes for preprocessor directives.
I tested brightwhite on my terminal and it looks better than grey on yellow,
so I think this is a solution. Amended.
Thanks. Pushed, 5144162a.
I copied the modification for `do_unindent()`. But in the case of
`length_of_white()` I found the old code less maintainable so it got
rewritten.
:| You didn't do as asked, so I have pushed my own version.
About the other patches... I can't judge whether they are relevant.
Someone else please chime in.
Benno
- [Nano-devel] [PATCH] Some improvements, Liu Hao, 2017/12/06
- Re: [Nano-devel] [PATCH] Some improvements, Liu Hao, 2017/12/07
- Re: [Nano-devel] [PATCH] Some improvements, Liu Hao, 2017/12/07
- Re: [Nano-devel] [PATCH] Some improvements, Benno Schulenberg, 2017/12/07
- Re: [Nano-devel] [PATCH] Some improvements, Liu Hao, 2017/12/07
- Re: [Nano-devel] [PATCH] Some improvements,
Benno Schulenberg <=
- Re: [Nano-devel] [PATCH] Some improvements, Liu Hao, 2017/12/10
- Re: [Nano-devel] [PATCH] Some improvements, Benno Schulenberg, 2017/12/10
- Re: [Nano-devel] [PATCH] Some improvements, Liu Hao, 2017/12/10
- Re: [Nano-devel] [PATCH] Some improvements to the c syntax, Benno Schulenberg, 2017/12/10
- Re: [Nano-devel] [PATCH] Some improvements to the c syntax, Liu Hao, 2017/12/10
- Re: [Nano-devel] [PATCH] Some improvements to the c syntax, Benno Schulenberg, 2017/12/11
- Re: [Nano-devel] [PATCH] Some improvements to the c syntax, Liu Hao, 2017/12/11
Re: [Nano-devel] [PATCH] Some improvements, Benno Schulenberg, 2017/12/07