Re: [Nano-devel] [PATCH] Some improvements

[Benno Schulenberg]

Op 10-12-17 om 06:37 schreef Liu Hao:
> On 2017/12/10 1:04, Benno Schulenberg wrote:
> > The new version does not color a lonely #else or #endif.
>
> Oops it was an oversight. ... well, how to work around it without look-ahead 
> assertions? :/

Don't know.  :|

> > Also, it is a drain on resources: opening a large C file now takes twice as 
> > long. The precalculation of the color info takes roughly five times as long 
> > as for the disabled coloring of multiline strings.  It was disabled to
> > avoid irritating slowdowns.  So, I don't think we can do the multiline
> > regexes for preprocessor directives.
> I was aware of it anyway, but I think 'large C files' are relatively rare.

True.

Hm...  Okay, if you fix the #endif and #else things (and maybe others),
then we're going to give it a try -- with the multiline command -- see
if we get any complaints.

I think #define should not color what comes after it.  Together with
#else and #endif it should be in a single-line color command.  Maybe
also #include should be in the single-line one?

> > I have pushed my own version.
> I have no objection to it as long as everything works expectantly.

Good.  Thanks.

Benno