Re: [Nano-devel] Nano Patch

[Michael Francis]

I don't have a particular preference. I saw other syntax files using icolor without specifying explicit ranges, so that's why I did it that way. Regardless, in this latest patch I attached I changed them to your patterns.

I also changed the keyword colors so they're no longer the same as string colors. I agree that they should not have been the same.

On Sun, Dec 10, 2017 at 7:39 AM, Benno Schulenberg <address@hidden> wrote:

Op 09-12-17 om 16:48 schreef Michael Francis:

I have a patch that improves PHP syntax highlighting for function and variable
names.

Thanks for that.

Hmm...  I don't know how the regex stuff works internally, but I'm
guessing that explicit ranges are faster than case-insensitive ones.
So, would you be okay with the following regexes?:

 # Function names.
color white "\<[A_Za-z_][A-Za-z_0-9]*\("
 # Variable names.
color cyan "\$[A-Za-z_][A-Za-z_0-9]*"


And as you appear to know PHP, don't you find it strange that nano
colors PHP keywords the same as strings?  If so, care to propose a
patch for that?

Benno

0002-syntax-php-color-keywords-differently-than-strings-a.patch
Description: Text Data